feat: add is_extended_promotional column to components#127
Open
openclaw-dev-ops wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add is_extended_promotional column to components#127openclaw-dev-ops wants to merge 1 commit intotscircuit:mainfrom
openclaw-dev-ops wants to merge 1 commit intotscircuit:mainfrom
Conversation
Add is_extended_promotional boolean derived from basic=0 AND preferred=1, identifying JLCPCB extended parts offered at basic pricing. - Add computed column on components table via DB optimization - Add to BaseComponent interface and DerivedTableSpec constraint - Add to all 38 derived table specs (extraColumns + mapToTable) - Add filter support in /components/list and /api/search routes - Add UI checkbox for Extended Promotional filter - Update generated Kysely types and cf-proxy types/handlers Closes tscircuit#92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
is_extended_promotionalboolean column across all component tables, derived from the existingbasicandpreferredcolumns in the source data.What are Extended Promotional parts?
JLCPCB "Extended Promotional" parts are normally-extended components temporarily offered at basic pricing (no $3 assembly fee). They are identified by
basic = 0 AND preferred = 1in the upstreamcache.sqlite3from yaqwsx/jlcparts.Changes
is_extended_promotionalcolumn to thecomponentstable (GENERATED ALWAYS AS (basic = 0 AND preferred = 1)) with an indexextraColumnsandmapToTable?is_extended_promotional=trueon/components/listand/api/searchData source
The
preferredcolumn already exists in the database (added via PR #99). Extended promotional =preferred=1 AND basic=0. No external API calls needed — this is purely derived from existing data./claim #92