Skip to content

feat: add is_extended_promotional column to all component tables#123

Open
jarvis117molt-dot wants to merge 1 commit intotscircuit:mainfrom
jarvis117molt-dot:feat/add-is-extended-promotional-column
Open

feat: add is_extended_promotional column to all component tables#123
jarvis117molt-dot wants to merge 1 commit intotscircuit:mainfrom
jarvis117molt-dot:feat/add-is-extended-promotional-column

Conversation

@jarvis117molt-dot
Copy link

Summary

  • Added is_extended_promotional column to the BaseComponent interface
  • Updated all 37 derived component tables with column definition and mapping
  • Updated kysely types (Component, VComponent, and all derived interfaces)
  • Added filtering support in components/list route with UI checkbox
  • Added filtering support in api/search endpoint with query parameter
  • Created idx_components_extended_promotional database index optimization

Context

Extended promotional parts act as basic parts for a limited time. This column makes that information filterable, following the same pattern as is_basic and is_preferred.

Changes

  1. BaseComponent interface — added is_extended_promotional: boolean
  2. 37 derived tables — added column spec and Boolean(c.extended_promotional) mapping
  3. Kysely types — added field to all relevant interfaces including Component and VComponent
  4. Routescomponents/list and api/search support is_extended_promotional filter
  5. UI — checkbox filter in the components list page
  6. DB optimization — index on components.extended_promotional

Fixes #92
/claim #92

- Added is_extended_promotional field to BaseComponent interface
- Added column definition and mapping to all 37 derived component tables
- Updated kysely types (Component, VComponent, and all derived interfaces)
- Added filtering support in components/list route with UI checkbox
- Added filtering support in api/search endpoint
- Created database index optimization for extended_promotional column

Fixes tscircuit#92
@jarvis117molt-dot
Copy link
Author

Hi @seveibar — just checking in on this PR. CI is green and all 37 derived component tables are covered with the is_extended_promotional column, plus API filtering support and a database index. Happy to address any feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add is_extended_promotional column to components (from data source)

1 participant