feat: add is_extended_promotional column to all component tables#123
Open
jarvis117molt-dot wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add is_extended_promotional column to all component tables#123jarvis117molt-dot wants to merge 1 commit intotscircuit:mainfrom
jarvis117molt-dot wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Added is_extended_promotional field to BaseComponent interface - Added column definition and mapping to all 37 derived component tables - Updated kysely types (Component, VComponent, and all derived interfaces) - Added filtering support in components/list route with UI checkbox - Added filtering support in api/search endpoint - Created database index optimization for extended_promotional column Fixes tscircuit#92
Author
|
Hi @seveibar — just checking in on this PR. CI is green and all 37 derived component tables are covered with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_extended_promotionalcolumn to the BaseComponent interfacecomponents/listroute with UI checkboxapi/searchendpoint with query parameteridx_components_extended_promotionaldatabase index optimizationContext
Extended promotional parts act as basic parts for a limited time. This column makes that information filterable, following the same pattern as
is_basicandis_preferred.Changes
is_extended_promotional: booleanBoolean(c.extended_promotional)mappingcomponents/listandapi/searchsupportis_extended_promotionalfiltercomponents.extended_promotionalFixes #92
/claim #92