feat: Add is_extended_promotional column to all component tables#120
Open
buildingvibes wants to merge 2 commits intotscircuit:mainfrom
Open
feat: Add is_extended_promotional column to all component tables#120buildingvibes wants to merge 2 commits intotscircuit:mainfrom
buildingvibes wants to merge 2 commits intotscircuit:mainfrom
Conversation
- Added is_extended_promotional field to Component interface in kysely types - Updated BaseComponent interface to include is_extended_promotional - Added is_extended_promotional column to all 37 derived component tables - Added database index optimization for extended_promotional column - Updated components/list and api/search routes to support filtering by extended promotional status - Extended promotional parts act as basic parts for a limited time, making this field important for cost optimization
Author
|
Note: The 2 test failures in CI are pre-existing and unrelated to this PR's changes. They're caused by a missing All 84 other tests pass, and the format-check and type-check CI jobs both pass successfully. |
79b150d to
b42c416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_extended_promotionalcolumn to the Component database interfaceis_extended_promotionalfieldis_extended_promotionalcolumn definition and mapping to all 37 derived component tablesextended_promotionalcolumn for faster queriesis_extended_promotionalquery parameterContext
Extended promotional parts are components that act as basic parts for a limited time period. Having this information available as a filterable column allows users to:
This implementation follows the same pattern as
is_basicandis_preferredcolumns, ensuring consistency across the codebase.Changes
extended_promotionalcolumn to thecomponentstable in kysely typesidx_components_extended_promotionalindex for query performanceTesting
The implementation follows the exact same pattern as the existing
is_preferredcolumn (added in #99), ensuring compatibility with the current architecture.Fixes #92
/claim #92