feat: Add is_extended_promotional column to all components#113
Open
MuhamadJuwandi wants to merge 1 commit intotscircuit:mainfrom
Open
feat: Add is_extended_promotional column to all components#113MuhamadJuwandi wants to merge 1 commit intotscircuit:mainfrom
MuhamadJuwandi wants to merge 1 commit intotscircuit:mainfrom
Conversation
Added is_extended_promotional boolean column to BaseComponent and all derived tables. Created logic to extract this flag from component 'extra' attributes.
techmannih
reviewed
Dec 28, 2025
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Add screenshot after running it locally.
Member
|
Join our discord for fast review and discussion. Feel Free to contribute. |
Author
Added verification script scripts/verify-extended-promo.ts and confirmed logic works locally. Screenshot attached.
|
Author
|
/claim #92 |
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
I believe this issue is already solved #99
Author
|
I've checked PR #99 , and it appears to only add the In this PR (#113), I've added the exact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92. This PR adds the 'is_extended_promotional' boolean column to BaseComponent and all derived tables. It includes logic to extract this flag from the component's 'extra' attributes.