fix: Add DRC checks support for async autorouters #720
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: David Anyatonwu <[email protected]>
Signed-off-by: David Anyatonwu <[email protected]>
| ) | ||
|
|
||
| // Ensure the circuit is fully rendered and async autorouting is complete | ||
| await circuit.renderUntilSettled() |
There was a problem hiding this comment.
do not use renderuntilsettled method use only render
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Signed-off-by: David Anyatonwu <[email protected]>
Signed-off-by: David Anyatonwu <[email protected]>
|
I do not understand why the snapshot is failing on the CI but passes locally @Anshgrover23 |
|
@onyedikachi-david have u ran |
I ran this |
|
@onyedikachi-david try to delete the original snapshot and then generate again see if this resolves. |
Yeah, I did that also during the last commit. |
|
@onyedikachi-david then maybe your test has some problem just debug man, ik you can do it. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
| @@ -146,11 +146,31 @@ export class Board extends Group<typeof boardProps> { | |||
| } | |||
|
|
|||
| doInitialPcbDesignRuleChecks() { | |||
| if (this.root?.pcbDisabled) return | |||
| if (this.getInheritedProperty("routingDisabled")) return | |||
| this.updatePcbDesignRuleChecks() | |||
There was a problem hiding this comment.
don't call lifecycle methods directly, you may need a hidden function e.g. _doDrcChecks()
|
|
||
| // Clear all trace errors | ||
| db.pcb_trace_error.list().forEach((error) => { | ||
| db.pcb_trace_error.delete(error.pcb_trace_error_id) |
There was a problem hiding this comment.
don't delete all pcb trace errors, only delete ones that are created from this board's DRC. You may need to store a property to indicate it was created by this Board
Fixes: #717
/claim #717