fix: separate component solids in STEP output#53
fix: separate component solids in STEP output#53omair445 wants to merge 3 commits intotscircuit:mainfrom
Conversation
Previously all component triangles were merged into a single ClosedShell, which violates STEP's requirement that each ManifoldSolidBrep has a closed, watertight boundary. Viewers silently drop the invalid merged solid. Now each component box gets its own ClosedShell and ManifoldSolidBrep, so resistor/capacitor blocks render correctly in STEP viewers. Also defaults includeComponents to true since most users expect component geometry in their exports. Fixes tscircuit#6
|
@omair445 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
added snapshot test showing the separated solids output — each component now gets its own ManifoldSolidBrep (board + 2 components = 3 separate solids) |
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
You need to fix this https://github.com/tscircuit/circuit-json-to-step/blob/main/test/repros/repro01/__snapshots__/repro01.snap.png
Also fix format
|
formatting fixed — just pushed the biome format changes. the snapshot test is passing now, showing all 3 separate solids (board + 2 components) as expected. let me know if you need me to regenerate the snapshot or if there's something specific about the png you want me to look at! |
|
Hey everyone, I am very very sorry I got stuck in work-related stuff and haven't been able to follow up on this. I am happy if anyone else can take care of this from here or if the maintainers want to push the final bits. Apologies again for the delay! |
|
this is not correct please read the issue carefully |
2 participants
hey, figured out why rectangles were missing in the STEP output.
root cause: all component triangles were being merged into a single
ClosedShell, creating an invalid STEP solid that viewers silently drop.fix: each component box now gets its own
ManifoldSolidBrep, and defaultedincludeComponentstotrue. the basics04 test case now correctly produces 3 separate solids (board + R1 + C1).all 11 tests pass.
resolves #6