fix: include component geometry by default to avoid missing output#52
Open
xiuqiang1995 wants to merge 1 commit intotscircuit:mainfrom
Open
fix: include component geometry by default to avoid missing output#52xiuqiang1995 wants to merge 1 commit intotscircuit:mainfrom
xiuqiang1995 wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
@xiuqiang1995 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
MustafaMulla29
requested changes
Feb 11, 2026
Contributor
MustafaMulla29
left a comment
There was a problem hiding this comment.
Please read the issue description, what it says
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing component/rectangle geometry in default STEP conversion flow by enabling component inclusion by default.
Changes
includeComponentsdefault behavior incircuitJsonToStep:options.includeComponents ?? true)includeComponentsis not explicitly passedWhy
Issue #6 reports missing rectangle-like resistor block geometry in output.
A key cause is default conversion excluding components unless explicitly enabled.
This patch makes default behavior safer/closer to user expectation.
Validation
Ran:
bun test test/repros/kicad-step/kicad-step.test.ts test/repros/repro02/repro02.test.tsResult:
Fixes #6