Skip to content

fix: include component geometry by default to avoid missing output#52

Open
xiuqiang1995 wants to merge 1 commit intotscircuit:mainfrom
xiuqiang1995:fix/issue-6-default-include-components
Open

fix: include component geometry by default to avoid missing output#52
xiuqiang1995 wants to merge 1 commit intotscircuit:mainfrom
xiuqiang1995:fix/issue-6-default-include-components

Conversation

@xiuqiang1995
Copy link

Summary

Fixes missing component/rectangle geometry in default STEP conversion flow by enabling component inclusion by default.

Changes

  • Change includeComponents default behavior in circuitJsonToStep:
    • from opt-in to default-on (options.includeComponents ?? true)
  • Update site UI default:
    • "Include components" checkbox is checked by default
  • Add regression test:
    • verifies component solids are present even when includeComponents is not explicitly passed
  • Minor README usage note update

Why

Issue #6 reports missing rectangle-like resistor block geometry in output.
A key cause is default conversion excluding components unless explicitly enabled.
This patch makes default behavior safer/closer to user expectation.

Validation

Ran:

bun test test/repros/kicad-step/kicad-step.test.ts test/repros/repro02/repro02.test.ts

Result:

  • 5 passed
  • 0 failed

Fixes #6

@vercel
Copy link

vercel bot commented Feb 11, 2026

@xiuqiang1995 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@MustafaMulla29 MustafaMulla29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the issue description, what it says

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine why rectangles are missing in output

2 participants