Skip to content

Fix missing rectangles by creating separate solids for each component #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwellyoung wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix missing rectangles by creating separate solids for each component #45

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c7f45
Fix missing rectangles by creating separate solids for each component
maxwellyoung Jan 19, 2026
36580f7
Fix component mesh generation to skip board mesh
maxwellyoung Jan 19, 2026
2220e7c
fix: include custom mesh components instead of skipping them
maxwellyoung Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions lib/mesh-generation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,22 +327,23 @@ export async function generateComponentMeshes(
renderBoardTextures: false,
})

// Extract or generate triangles from component boxes
const allTriangles: GLTFTriangle[] = []
for (const box of scene3d.boxes) {
// Process each component box individually to create separate STEP solids
// (STEP requires each solid to have its own closed, watertight boundary)
for (let i = 0; i < scene3d.boxes.length; i++) {
const box = scene3d.boxes[i]
let boxTriangles: GLTFTriangle[]

if (box.mesh && "triangles" in box.mesh) {
allTriangles.push(...box.mesh.triangles)
boxTriangles = box.mesh.triangles
} else {
// Generate simple box mesh for this component
const boxTriangles = createBoxTriangles(box)
allTriangles.push(...boxTriangles)
boxTriangles = createBoxTriangles(box)
}
}

// Create STEP faces from triangles if we have any
if (allTriangles.length > 0) {
if (boxTriangles.length === 0) continue

// Transform triangles from GLTF XZ plane (Y=up) to STEP XY plane (Z=up)
const transformedTriangles = allTriangles.map((tri) => ({
const transformedTriangles = boxTriangles.map((tri) => ({
vertices: tri.vertices.map((v) => ({
x: v.x,
y: v.z, // GLTF Z becomes STEP Y
Expand All @@ -354,17 +355,19 @@ export async function generateComponentMeshes(
z: tri.normal.y, // GLTF Y becomes STEP Z
},
}))

const componentFaces = createStepFacesFromTriangles(
repo,
transformedTriangles as any,
)

// Create closed shell and solid for components
// Create closed shell and solid for this component
const componentShell = repo.add(
new ClosedShell("", componentFaces as any),
)
const componentName = box.name || `Component_${i + 1}`
const componentSolid = repo.add(
new ManifoldSolidBrep("Components", componentShell),
new ManifoldSolidBrep(componentName, componentShell),
)
solids.push(componentSolid)
}
Expand Down