fix: process each component box as separate ManifoldSolidBrep in STEP export#42
Open
LiamConner10 wants to merge 1 commit intotscircuit:mainfrom
Open
fix: process each component box as separate ManifoldSolidBrep in STEP export#42LiamConner10 wants to merge 1 commit intotscircuit:mainfrom
LiamConner10 wants to merge 1 commit intotscircuit:mainfrom
Conversation
… export Previously all triangles from all component boxes were merged into a single ClosedShell, which violated STEP's requirement that each solid have its own watertight boundary. This caused components to be missing from STEP output. Now each box from scene3d.boxes is processed individually, creating a separate ManifoldSolidBrep for each component with its own ClosedShell. Fixes tscircuit#6 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scene3d.boxesis now processed individuallyManifoldSolidBrepfor each component with its ownClosedShellClosedShell, violating STEP's requirement that each solid have its own watertight boundaryRoot Cause
The original code collected ALL triangles from ALL component boxes into a single
allTriangles[]array, then created ONEClosedShelland ONEManifoldSolidBrepfrom them. This violated STEP's constraint that each solid must have its own closed, watertight boundary - you can't merge multiple disconnected meshes into one shell.The Fix
Process each box separately in the loop, creating individual solids:
Test Plan
bun test)bunx tsc --noEmit)mesh-with-component01Fixes #6
🤖 Generated with Claude Code