Skip to content

Conversation

seveibar
Copy link
Contributor

@seveibar seveibar commented Sep 9, 2025

Summary

  • prefer explicit model URLs over footprinter strings
  • load KiCad .wrl models when footprinter string begins with kicad:
  • remove redundant getModelUrl test file

Testing

  • BUN_UPDATE_SNAPSHOTS=1 bun test tests/convert-3d-view-to-svg-top-view.test.ts tests/convert-3d-view-to-svg-with-multiple-elements.test.ts
  • bun test tests/remove-existing-canvases.test.ts

https://chatgpt.com/codex/tasks/task_b_68bfbaa4e150832e8f944f342f9aaae7

Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
3d-viewer Ready Ready Preview Comment Sep 9, 2025 5:44am

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +17 to +18
// Handle STL/OBJ/WRL/GLTF models first
const url = getModelUrl(component) ?? component.model_gltf_url

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Keep GLTF model priority over footprinter URLs

By resolving getModelUrl(component) ?? component.model_gltf_url, a component that provides both a model_gltf_url and a kicad: footprinter will now fetch the synthesized .wrl first and never reach the GLTF. Prior behaviour (and the summary that says explicit model URLs should be preferred over footprinter strings) rendered the provided GLTF, which is typically the higher fidelity asset. This reversal will cause components that ship both assets to render the fallback instead of the intended GLTF model. The same precedence is used in AnyCadComponent, so the regression affects both render paths. Consider checking model_gltf_url before translating the footprinter string or moving GLTF support into getModelUrl ahead of the footprinter fallback.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant