Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better type handling and error reporting #294

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

Newbie012
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 880e39d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@ts-safeql/eslint-plugin Minor
@ts-safeql/generate Minor
@ts-safeql-demos/basic-flat-config Patch
@ts-safeql-demos/basic-migrations-raw Patch
@ts-safeql-demos/basic-transform-type Patch
@ts-safeql-demos/basic Patch
@ts-safeql-demos/big-project Patch
@ts-safeql-demos/config-file-flat-config Patch
@ts-safeql-demos/from-config-file Patch
@ts-safeql-demos/multi-connections Patch
@ts-safeql-demos/playground Patch
@ts-safeql-demos/postgresjs-custom-types Patch
@ts-safeql-demos/postgresjs-demo Patch
@ts-safeql-demos/vercel-postgres Patch
@ts-safeql/shared Minor
@ts-safeql/sql-ast Minor
@ts-safeql/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
safeql ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 11:30pm

@gajus
Copy link
Contributor

gajus commented Dec 3, 2024

This is neat!

@gajus
Copy link
Contributor

gajus commented Dec 5, 2024

@Newbie012 What can be expected in terms of the release timeline?

Just debating whether to release safeql to the team with or without this change.

@Newbie012 Newbie012 marked this pull request as ready for review December 5, 2024 23:21
@Newbie012
Copy link
Collaborator Author

Any minute now. I first had to refactor the error positioning logic before adding this feature

@Newbie012 Newbie012 changed the title wip: select where enum column equals to one of the string literals select where enum column equals to one of the string literals Dec 5, 2024
@Newbie012 Newbie012 changed the title select where enum column equals to one of the string literals feat: better type handling and error reporting Dec 5, 2024
@Newbie012 Newbie012 merged commit f1a976d into main Dec 5, 2024
3 checks passed
@Newbie012 Newbie012 deleted the feat-better-type-comparison branch December 5, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants