Sinden lightgun #69
Open
Sinden lightgun #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is usefull for multiple instance of supermodel networked on the same machine.
-pos=<x>,<y> Position [Default: centered] -borderless Windowed mode with no border These 2 settings are usefull when setting up a multiplayer game on one machine. Example for 4 windows in fullHD: start "Master" /D"Master_P4" Supermodel.exe -input-system=sdl ..\ROMS\dayto2pe.zip -res=960,540 -borderless -pos=0,0 start "Slave1" /D"Slave1_P4" Supermodel.exe -input-system=sdl ..\ROMS\dayto2pe.zip -res=960,540 -borderless -pos=960,0 start "Slave2" /D"Slave2_P4" Supermodel.exe -input-system=sdl ..\ROMS\dayto2pe.zip -res=960,540 -borderless -pos=0,540 start "Slave3" /D"Slave3_P4" Supermodel.exe -input-system=sdl ..\ROMS\dayto2pe.zip -res=960,540 -borderless -pos=960,540
…ideo based lightgun.
…into sinden-lightgun REsolved Conflicts: Src/OSD/SDL/Main.cpp
…into sinden-lightgun Rsolved Conflicts: Src/OSD/SDL/Crosshair.cpp Src/OSD/SDL/Crosshair.h
trzy
requested changes
Mar 23, 2023
Owner
trzy
left a comment
trzy
left a comment
There was a problem hiding this comment.
I am at GDC so I have not yet tested and will test Sunday or Monday when I return home. In the meantime, these are just simple cosmetic changes I easily identified. Also, please update Rules.inc to include WhiteBorder for gcc builds.
| : m_config(config) | ||
| { | ||
| m_vertexShader = nullptr; | ||
| m_fragmentShader = nullptr; |
|
|
||
| //if we want to draw a white border, we have also to put a black border around it so we are sure lightgun will find it... | ||
| if (s_whiteBorder->IsEnabled()) | ||
| { |
| #include "Supermodel.h" | ||
| #include "Graphics/New3D/New3D.h" | ||
| #include "Inputs/Inputs.h" | ||
| #include "basicDrawable.h" |
Owner
There was a problem hiding this comment.
basicDrawable.h should be named BasicDrawable.h. Also please use full path (OSD/SDL/BasicDrawable.h)
| CWhiteBorder::CWhiteBorder(const Util::Config::Node& config) : m_config(config) | ||
| { | ||
| m_drawWhiteBorder = m_config["DrawWhiteBorder"].ValueAs<bool>(); | ||
| m_vertexShader = nullptr; |
Owner
There was a problem hiding this comment.
All of these should probably just be moved up into the initializer list.
| #include "Supermodel.h" | ||
| #include "Graphics/New3D/New3D.h" | ||
| #include "Inputs/Inputs.h" | ||
| #include "basicDrawable.h" |
|
|
||
| void GenQuad(std::vector<CBasicDrawable::BasicVertex>& verts, unsigned int x, unsigned int y, unsigned int w, unsigned int h); | ||
| public: | ||
| CWhiteBorder(const Util::Config::Node& config); |
Owner
There was a problem hiding this comment.
Blank line before public, please.
Owner
|
Is this still requested? If so, please resolve conflicts or will close it out without merging next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a white border around image to be compatible with "Sinden-like" video based lightgun.
Activate with "-draw-white-border" command line option.
Merged with new Crosshair code.