Skip to content

Conversation

@wsxdrfvyhn
Copy link

@wsxdrfvyhn wsxdrfvyhn commented Jul 24, 2025

this fix does not seem to interfere with any other functionality in my testing
-config-inputs now functions as it would prior to commit 46453e

@toxieainc
Copy link
Contributor

Seems this was my bad, sorry. Could you please add an additional comment that the parameter passing is intended like this?
(as static analysis warned me, that this could be the wrong way around due to the naming)

@wsxdrfvyhn
Copy link
Author

done, will look further into it to see if i can come up with an explanation for why exactly this is needed

@trzy
Copy link
Owner

trzy commented Jul 28, 2025

This looked gross to me but I looked at the logic and it made sense:

 // See which sources activated to begin with and from here on ignore these (this stops badly calibrated axes that are constantly "active"
  // from preventing the user from exiting read loop)

The badSources array is being initialized by this call to any "noisy" sources that are initially active. Let me test this tonight and then merge it.

I wonder if it makes sense to make the code more explicit by adding a noisySources vector, and then explicitly copying that to badSources after that initial CheckAllSources() call. It would stop automatic checkers from complaining. Might also add a more detailed comment about what is going on, although I think the existing comment Nik originally makes clear what is happening.

@dukeeeey
Copy link
Collaborator

Is there any update on this? Unfortunately I don't have any controllers to test with atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants