Add network output, based on MAME's network output system #253

njz3 · 2025-04-25T20:57:07Z

Add TCP server socket 8000 and UDP (broadcast) 8001 for network outputs.

trzy

It's a good feature but substantial rework needed. I don't like the Windows-specific nature of this. I think it's unnecessary: UDP should be done via SDL2_net, not Winsock, and threading should be done with std::thread, not the Windows API.

Also, make sure to add the Supermodel file header to each source file.

trzy · 2025-04-25T21:09:01Z

Src/Network/UDPPacket.h

+	struct Packet
+	{
+
+		static const UINT32 BUFFER_SIZE_UDP = 1460;


Can we convert tabs to spaces everywhere? I think we are using a 4-character tab stop.

trzy · 2025-04-25T21:11:20Z

Src/Network/UDPSend.h

+#include <vector>
+#include <thread>
+
+namespace SMUDP


Do we need this namespace at all?

trzy · 2025-04-25T21:12:00Z

Src/Network/WinSockWrap.cpp

+
+#pragma comment(lib, "ws2_32.lib")
+
+WinSockWrap::WinSockWrap()


Why is Winsock needed? SDL2_net has UDP, to my knowledge. This should be platform-agnostic, similar to the netplay TCP code, no?

trzy · 2025-04-25T21:13:18Z

Src/OSD/SDL/Main.cpp

 #endif
  config.Set("Outputs", "none");
  config.Set("DumpTextures", false);
+  config.Set("NetOutputsWithLF", "1");


I think we can probably drop the Net prefix here and just group these below "Outputs".

trzy · 2025-04-25T21:13:59Z

Src/OSD/SDL/Main.cpp

 #endif
  config.Set("Outputs", "none");
  config.Set("DumpTextures", false);
+  config.Set("NetOutputsWithLF", "1");


OutputsWithLF should probably be a bool rather than int?

trzy · 2025-04-25T21:15:47Z

Src/OSD/Windows/NetOutputs.cpp

+    // Will do SendUdpBroadcastWithId();
+}
+
+LRESULT CNetOutputs::CreateServerThread()


Please refactor to eliminate all Windows dependencies here. std::thread can be used. No need for any Windows functions or types like LRESULT, DWORD, etc.

trzy · 2025-04-25T21:16:22Z

VS2008/Supermodel.vcxproj

    <ClCompile Include="..\Src\Network\SimNetBoard.cpp" />
    <ClCompile Include="..\Src\Network\TCPReceive.cpp" />
    <ClCompile Include="..\Src\Network\TCPSend.cpp" />
+    <ClCompile Include="..\Src\Network\TCPSendAsync.cpp" />


Don't forget to update Rules.inc in Makefiles.

dukeeeey · 2025-04-25T21:19:25Z

All the network stuff is copy/paste from much earlier versions of supermodel before the networking code really worked. They shouldn't be needed I don't think for the mame outptut stuff. Tbh not even sure what it is / for.

trzy · 2025-04-25T21:21:14Z

All the network stuff is copy/paste from much earlier versions of supermodel before the networking code really worked. They shouldn't be needed I don't think for the mame outptut stuff. Tbh not even sure what it is / for.

I've never used this feature but Nik hooked up the original output system to work with something called MameHooker (heh). It's for the various lights on the cabinets, for those who want to emulate those or implement them on custom cabs.

trzy · 2025-04-25T21:22:34Z

The main thing is that the current outputs system is constrained to Windows but this one could actually be platform-independent. Better to do that.

dukeeeey · 2025-04-25T21:23:16Z

All the network code is what I wrote for spindizzi when we trying to get networking working. It wasn't required for the mame output stuff. In the end i rewrote the network code for SDL.

njz3 · 2025-04-25T21:44:06Z

@dukeeeey That's something I have done a long time ago for my own usage (forcefeedback software), maybe a few years ago, and forgot about it until somebody ask me an update today.
I simply updated the branch up to current master, and commited the files which explains why it is using old code from you.

When I will have spare time I will check your code review. Thank for spending time reviewing it.

dukeeeey · 2025-04-25T21:46:44Z

The only files you need are netoutputs.cpp / h. I am pretty sure the rest isn't needed.

6Bolt · 2025-07-09T21:50:51Z

Hello, I am Darren, also known as 6Bolt, the coder of Hook Of The Reaper program. Github link below.

https://github.com/6Bolt/Hook-Of-The-Reaper

Hook Of The Reaper is an alternative to the aging MameHooker. Since it is a newer program, I didn't want to do the windows to windows communication. I get the output signals from TCP port 8000, on the localhost. This is supported by MAME, DemulShooter, and now nixxou's 3 light gun Emulator builds. HOTR has taken over MameHooker in the light gun community.

I have your SuperModel v0.3.1-26-g95968f3, which supported the network output. I have the needed DefaultLG game files on my website. These are similar to MameHooker ini game files, but work for any DefaultLG light gun, with no modification. To enable it , I had to put 'outputs = net' in the Supermodel.ini file. Link to game files below.

https://hotr.6bolt.com/pmwiki.php/GameFiles/SuperModel

Looking at the current code, the Src/OSD/Windows/NetOutputs.h/cpp is not there anymore. Was it moved to a different location? Or was Net Outputs removed? If not, how do you enable it? As light gun players are now wanting to play the light gun games with HOTR.

trzy · 2025-07-09T23:05:54Z

I believe NetOutputs.cpp was part of a PR that was not approved as it needed considerable refactoring. We would like a solution that is not Windows dependent if it is using TCP sockets. There is already socket code in Supermodel for netplay using SDL, which is cross-platform. If you’d like to add a TCP based output system, that would be great, but it should not contain any Windows-specific code (unless there is a very good reason). Sent from my iPhoneOn Jul 9, 2025, at 5:51 PM, Darren ***@***.***> wrote:6Bolt left a comment (trzy/Supermodel#253) Hello, I am Darren, also known as 6Bolt, the coder of Hook Of The Reaper program. Github link below. https://github.com/6Bolt/Hook-Of-The-Reaper Hook Of The Reaper is an alternative to the aging MameHooker. Since it is a newer program, I didn't want to do the windows to windows communication. I get the output signals from TCP port 8000, on the localhost. This is supported by MAME, DemulShooter, and now nixxou's 3 light gun Emulator builds. HOTR has taken over MameHooker in the light gun community. I have your SuperModel v0.3.1-26-g95968f3, which supported the network output. I have the needed DefaultLG game files on my website. These are similar to MameHooker ini game files, but work for any DefaultLG light gun, with no modification. To enable it , I had to put 'outputs = net' in the Supermodel.ini file. Link to game files below. https://hotr.6bolt.com/pmwiki.php/GameFiles/SuperModel Looking at the current code, the Src/OSD/Windows/NetOutputs.h/cpp is not there anymore. Was it moved to a different location? Or was Net Outputs removed? If not, how do you enable it? As light gun players are now wanting to play the light gun games with HOTR. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

6Bolt · 2025-07-09T23:29:17Z

OK, I understand. I only use Windows stuff, only when I have too.

I have converted nixxou's MameOutputSender program from windows to windows communications to network TCP communications. This is used on his light gun builds for Dolphin, Duck Station, and PCSX2.

Currently I am busy with the Hook Of The Reaper project. When that is completed, I could get it done. But that would be 6-9 months from now.

njz3 · 2025-07-10T07:00:42Z

It that's ok for @dukeeeey and @trzy , I will have a look to using SDL_net API. (Also need some weeks/months to do that.)

njz3 added 2 commits April 25, 2025 22:47

Add network output, based on MAME's network output system

21d4350

reverted PlatformToolset to v142

c13983f

trzy requested changes Apr 25, 2025

View reviewed changes

bagelswitch added a commit to bagelswitch/Supermodel that referenced this pull request Oct 21, 2025

Incorporate parts of (TCP:8000 network outputs) upstream PR trzy#253

d5a8f74


		#pragma comment(lib, "ws2_32.lib")

		WinSockWrap::WinSockWrap()

Add network output, based on MAME's network output system #253

Are you sure you want to change the base?

Add network output, based on MAME's network output system #253

Uh oh!

Conversation

njz3 commented Apr 25, 2025

Uh oh!

trzy left a comment

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

trzy Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

dukeeeey commented Apr 25, 2025

Uh oh!

trzy commented Apr 25, 2025

Uh oh!

trzy commented Apr 25, 2025

Uh oh!

dukeeeey commented Apr 25, 2025

Uh oh!

njz3 commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukeeeey commented Apr 25, 2025

Uh oh!

6Bolt commented Jul 9, 2025

Uh oh!

trzy commented Jul 9, 2025 via email

Uh oh!

6Bolt commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

njz3 commented Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

njz3 commented Apr 25, 2025 •

edited

Loading

6Bolt commented Jul 9, 2025 •

edited

Loading