Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra mask for updated individual measure #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmythms
Copy link
Collaborator

@jmythms jmythms commented Feb 13, 2025

This fixes #456 by adding an extra mask to update the package if the individual measures in package were updated.

@jmythms jmythms self-assigned this Feb 13, 2025
@jmythms
Copy link
Collaborator Author

jmythms commented Feb 13, 2025

These are the changes you will see. The config file has

  ...
  ecm_files: ["Residential Walls, IECC c. 2021", "Best Com. Air Sealing (Exist)"]
  ecm_files_regex: []
  ecm_packages: ["ENERGY STAR Res. ASHP (FS) + Env."]
  ...

After updating only individual Residential Walls, IECC c. 2021.json measure and running the python scout/run_batch.py script:

Current behavior: A new Residential Walls, IECC c. 2021.pkl.gz file is created while the package file ENERGY STAR Res. ASHP (FS) + Env..pkl.gz which has Residential Walls, IECC c. 2021 is not recreated. Please note the modified time of all files.
image

New behavior: The package file ENERGY STAR Res. ASHP (FS) + Env..pkl.gz which has Residential Walls, IECC c. 2021 is recreated while the other file remains untouched. Please note the modified time of all files.
image

@jmythms
Copy link
Collaborator Author

jmythms commented Feb 13, 2025

@jtlangevin Would be awesome if you could confirm this fix gets us to the expected behavior.

@jmythms
Copy link
Collaborator Author

jmythms commented Feb 13, 2025

The failed tests will pass after pulling in changes from PR#454. (The deprecated actions/upload-artifact which causes the failure will be updated when #454 is merged.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch run doesn't re-initiate package preparation even when individual measures in package were updated
1 participant