Ignore events which are not relevant for this module's event listener#99
Open
fredden wants to merge 2 commits intotrustpilot:masterfrom
Open
Ignore events which are not relevant for this module's event listener#99fredden wants to merge 2 commits intotrustpilot:masterfrom
fredden wants to merge 2 commits intotrustpilot:masterfrom
Conversation
Author
|
@vilgro, please can this be merged in (and a new version released)? |
Author
|
@arunas-stonis, please can you merge this in (and release a new version)? |
Author
|
@trustiewatson it looks like you're on the integrations team at Trustpilot, and have sufficient permissions to commit / push to other repositories in this organisation. Please can you merge this and tag new version? (See also the other open pull request which would be helpful to get merged in too.) |
|
Hi! This error is causing our client's JS logs to be clogged with errors; This is blocking the triage of other issues. My developer is creating a patch using Fredden's code. I thought it was worth highlighting that a problem with the module for 3+ years has not been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95