Skip to content

Make titles for ACL and menu translatable. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmalyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make titles for ACL and menu translatable. #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions etc/acl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Acl/etc/acl.xsd">
xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
<acl>
<resources>
<resource id="Magento_Backend::admin">
<resource id="Trustpilot_Reviews::trustpilot" title="Truspilot Reviews Menu" sortOrder="10"></resource>
<resource id="Trustpilot_Reviews::trustpilot" title="Truspilot Reviews Menu" translate="title" sortOrder="10" />
<resource id="Magento_Backend::stores">
<resource id="Magento_Backend::stores_settings">
<resource id="Magento_Config::config">
<resource id="Trustpilot_Reviews::settings" title="Trustpilot Reviews Settings">
<resource id="Trustpilot_Reviews::settings" title="Trustpilot Reviews Settings" translate="title">
<!-- this resource id we can use in system.xml for section -->
<resource id="Trustpilot_Reviews::configuration" title="Trustpilot Reviews Section" sortOrder="2" />
<resource id="Trustpilot_Reviews::configuration" title="Trustpilot Reviews Section" translate="title" sortOrder="2" />
</resource>
</resource>
</resource>
Expand Down
1 change: 1 addition & 0 deletions etc/adminhtml/menu.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<menu>
<add id="Trustpilot_Reviews::Trustpilot"
title="Trustpilot"
translate="title"
module="Trustpilot_Reviews"
sortOrder="9999"
action="trustpilot_reviews/trustpilot"
Expand Down