feat: add custom metrics, and an initial cache size metric #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
force-pushed
the
feature/metrics_1
branch
from
dbf75b0 to
8a22968
Compare
helio-frota
reviewed
Feb 5, 2025
| @@ -141,19 +131,14 @@ pub fn init_tracing(name: &str, tracing: Tracing) { | |||
| INIT.call_once(init_no_tracing); | |||
| } | |||
| Tracing::Enabled => { | |||
| init_otlp(name); | |||
| init_otlp_tracing(name); | |||
helio-frota
approved these changes
Feb 5, 2025
Closed
|
|
|
@jcrossley3 fixed that annoying logs for actix-web-prom #335 without actix-web-prom we can remove that as well 👍 |
chirino
approved these changes
Feb 5, 2025
| let graph_cache = graph_cache.clone(); | ||
| meter | ||
| .u64_observable_gauge("cache_size") | ||
| .with_callback(move |inst| inst.observe(graph_cache.size_used(), &[])) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1255