Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add index for organizations by name #1250

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Feb 5, 2025

A primary way of finding Organizations is "by name". I think we should have an index for that.

A primary way of finding Organizations is "by name". I think we should
have an index for that.
@ctron ctron added the bug Something isn't working label Feb 5, 2025
@ctron ctron added this to the RHTPA 2.0.0 milestone Feb 5, 2025
@ctron ctron enabled auto-merge February 5, 2025 12:56
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this proved by showing a slow performing query plan improved ? How many organisations will we ever have eg. if its less then a thousand a seq scan is going to be super fast (and internally cached in db)... alternately adding this index will not hurt anything as it will not take a lot of time during ingestion or maintaining so LGTM!

@ctron ctron added this pull request to the merge queue Feb 5, 2025
Merged via the queue into trustification:main with commit ade3bc9 Feb 5, 2025
5 checks passed
@ctron ctron deleted the feature/index_1 branch February 5, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants