Fix issue with duplicate CDX nodes #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub enum Outcome<T> { | ||
| Existed(T), |
There was a problem hiding this comment.
minor: I do not fully understand the decomposition of Existed and Added state .... I mean I guess we could infer on True/False on Added ... so we want to sometimes add over an existed ... a few words explaining the intent of Outcome probably would help.
| impl MigrationTrait for Migration { | ||
| async fn up(&self, manager: &SchemaManager) -> Result<(), DbErr> { | ||
| manager | ||
| .create_index( |
There was a problem hiding this comment.
thx for this - I believe we had these before and after the refactoring into source_document .. not sure when/why this happened - glad they are back.
JimFuller-RedHat
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Closes: #1236, #303