Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add an ai feature so that ai features are not compiled by default. #1221

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Jan 30, 2025

Fixes #1219

@chirino
Copy link
Contributor Author

chirino commented Jan 30, 2025

So this basically moves the creation of the conversations table to another migrations table.

If someone was running a default dev version of trustd, then he might expect the conversations table to not exist for him after taking this change... but that's not the case. Should I add a migration to delete the conversations table?

@ctron
Copy link
Contributor

ctron commented Jan 31, 2025

This also seems to remove the APIs from the openAPI spec. Is that intentional?

@chirino
Copy link
Contributor Author

chirino commented Jan 31, 2025

This also seems to remove the APIs from the openAPI spec. Is that intentional?

Yes. They shouldn't be part of the released API until the feature is enabled by default. If you want to add them back openapi spec doc, say for development purposes, run: cargo xtask-ai openapi

Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: We might want to consider adding https://github.com/frewsxcv/cargo-all-features at some point.

@ctron ctron added this pull request to the merge queue Feb 3, 2025
Merged via the queue into trustification:main with commit 8735ebd Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the AI endpoint => applicable for V 2.0
2 participants