Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Gathering metrics at development time #1214

Merged
merged 1 commit into from
Jan 30, 2025
Merged

feat: Gathering metrics at development time #1214

merged 1 commit into from
Jan 30, 2025

Conversation

helio-frota
Copy link
Collaborator

@helio-frota helio-frota commented Jan 29, 2025 •
edited
Loading

  • Adds prometheus to existing compose file
  • Avoids conflicts with current custom metrics configs
  • Moved otel dev docs to docs/otel.md
  • Renamed tracing.rs to otel.rs as now it contains metrics signal

2025-01-29_08-44

@helio-frota
feat: Gathering metrics at development time
5e34648 
* Adds prometheus to existing compose file
* Avoids conflicts with current custom metrics configs
* Moved otel dev docs to docs/otel.md
* Renamed tracing.rs to otel.rs as now it contains metrics signal
@helio-frota helio-frota linked an issue Jan 29, 2025 that may be closed by this pull request
OTEL metrics - Enable at development time #1197
Closed
@helio-frota helio-frota requested a review from ctron January 29, 2025 12:14
@helio-frota
Copy link
Collaborator Author

helio-frota commented Jan 29, 2025 •
edited
Loading

Avoids conflicts with current custom metrics configs

Actually we don't have any custom metrics atm.
If I'm not wrong we have the infra-bits for custom metrics using prometheus crate.

As we can add custom metrics without prometheus crate link
I'm not sure if we should merge this PR, or update this PR removing both prometheus and actix-web-prom crates and related codes, and then merge.

@helio-frota helio-frota added this pull request to the merge queue Jan 30, 2025
@helio-frota helio-frota mentioned this pull request Jan 30, 2025
Closed
Merged via the queue into trustification:main with commit 9f2764d Jan 30, 2025
3 checks passed
@helio-frota helio-frota deleted the otel-metrics-enabled-dev-time branch January 30, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTEL metrics - Enable at development time
2 participants
@helio-frota @ctron