normalise Contains relationships #1209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimFuller-RedHat
force-pushed
the
normalise-relationships
branch
from
ac92c3e to
cdb3bcd
Compare
|
I like the PR in general. I just not sure about the migration part. To my understanding, we're adding relationsships, not using the old variants. Why not rename the relationships, and swap left/right for the ones we change in the migration? |
JimFuller-RedHat
force-pushed
the
normalise-relationships
branch
from
cdb3bcd to
f272e14
Compare
oh right the migration should also actually migrate the relationship data as well ;) |
JimFuller-RedHat
force-pushed
the
normalise-relationships
branch
from
f272e14 to
8ebaece
Compare
|
superseded by #1213 ... moving to work over there and closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in #1190 - we want to invert relationships to force a directed graph with all relationships going downwards.