Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr for external references #1200

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JimFuller-RedHat
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat commented Jan 24, 2025

@JimFuller-RedHat JimFuller-RedHat self-assigned this Jan 24, 2025
@JimFuller-RedHat JimFuller-RedHat marked this pull request as draft January 24, 2025 13:38
@JimFuller-RedHat JimFuller-RedHat force-pushed the adr-external-references branch 2 times, most recently from a056048 to c41ecff Compare January 25, 2025 04:56
Copy link
Contributor

@chirino chirino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimFuller-RedHat JimFuller-RedHat force-pushed the adr-external-references branch 6 times, most recently from a6867e7 to 0c490d6 Compare January 27, 2025 10:51
@JimFuller-RedHat JimFuller-RedHat force-pushed the adr-external-references branch 2 times, most recently from 3c2d0ce to 2f5f624 Compare January 30, 2025 05:58
@JimFuller-RedHat JimFuller-RedHat force-pushed the adr-external-references branch 13 times, most recently from 5a4a688 to 691197b Compare January 30, 2025 10:07
@JimFuller-RedHat JimFuller-RedHat force-pushed the adr-external-references branch 3 times, most recently from 22638f2 to 1714c73 Compare January 30, 2025 10:15
@chirino
Copy link
Contributor

chirino commented Jan 30, 2025

Now that we have some example record entries written down, we should think about the types of queries that the analysis layer will do to find the related nodes for these 3 external ref types. That may reveal the need for some additional indexed fields.

@JimFuller-RedHat
Copy link
Collaborator Author

JimFuller-RedHat commented Jan 30, 2025

I can flesh out the analysis graph queries though they will be similar to what we do today aka search sbom_node table then do petgraph query ... for external node we would be external_sbom_package_node then petgraph query - observation - the ADR is not a full blown design spec eg. we are going to find out some things out when we go implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants