-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr for external references #1200
base: main
Are you sure you want to change the base?
Conversation
a056048
to
c41ecff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a6867e7
to
0c490d6
Compare
0c490d6
to
6082c7b
Compare
3c2d0ce
to
2f5f624
Compare
5a4a688
to
691197b
Compare
22638f2
to
1714c73
Compare
1714c73
to
d429993
Compare
Now that we have some example record entries written down, we should think about the types of queries that the analysis layer will do to find the related nodes for these 3 external ref types. That may reveal the need for some additional indexed fields. |
I can flesh out the analysis graph queries though they will be similar to what we do today aka search sbom_node table then do petgraph query ... for external node we would be external_sbom_package_node then petgraph query - observation - the ADR is not a full blown design spec eg. we are going to find out some things out when we go implement. |
Preview: https://github.com/trustification/trustify/blob/adr-external-references/docs/adrs/00003-external-references.md