Trying to come with more clarity in tests #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Crossley <[email protected]>
|
@chirino do we hate this? 😄 |
chirino
reviewed
Jan 24, 2025
| assert_eq!(1, matches.len()); | ||
| assert_eq!( | ||
| response.pointer("/items/0/sbom_id"), | ||
| response.pointer("/items/0/deps/0/sbom_id") |
There was a problem hiding this comment.
Don't hate it but I do think assuming the array position of the element could be considered brittle. Is that PackageOf relationship pointing at the expected package?
There was a problem hiding this comment.
You could include additional assertions about the lengths of the relevant arrays like I do in the test below, e.g.
assert!(response.pointer("/items/0/deps/1").is_none());
The PackageOf relationship is asserted on lines 663-666.
I don't like the pointer path as much as your ContainsSubset trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.