Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for issue trustification#1151: Denote upstream relationship from CycloneDX #1169

Closed
wants to merge 1 commit into from

Conversation

chirino
Copy link
Contributor

@chirino chirino commented Jan 21, 2025

No description provided.

@chirino chirino changed the title Pedigree Add unit tests for issue trustification#1151: Denote upstream relationship from CycloneDX Jan 21, 2025
@chirino
Copy link
Contributor Author

chirino commented Jan 21, 2025

This resolves #1151

@chirino chirino marked this pull request as ready for review January 21, 2025 02:08
@jcrossley3
Copy link
Contributor

I guess you didn't see #1168 , huh?

One of us is wrong -- probably me -- because as I understood the issue, I needed to swap the left and right sides of the relationship in the ingestor. I do show the relationships in both root-component and deps but I could be passing the wrong purl's to each. 🤷

Also, that purl endpoint isn't correct -- it's only working because the bom-ref's are actual purl's in the test-data, but I don't think we can rely on that, so @ctron suggested we not expose the relationships through that endpoint at all.

We can discuss further tomorrow.

@chirino
Copy link
Contributor Author

chirino commented Jan 21, 2025

@jcrossley3 rebased off your changes, only thing this PR adds now is an additional unit test for the purl endpoint.

@jcrossley3
Copy link
Contributor

@jcrossley3 rebased off your changes, only thing this PR adds now is an additional unit test for the purl endpoint.

I'm in the process of reverting the purl endpoint changes, per @JimFuller-RedHat, so no relationships will be returned from it. I think you can safely delete this PR. 😄

@chirino
Copy link
Contributor Author

chirino commented Jan 21, 2025

sounds good.

@chirino chirino closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants