refactor: drop Transactional and ConnectionOrTransaction #1069
Conversation
modules/analysis/src/endpoints.rs
Outdated
| user: UserInformation, | ||
| authorizer: web::Data<Authorizer>, | ||
| _: Require<ReadSbom>, | ||
| ) -> actix_web::Result<impl Responder> { | ||
| authorizer.require(&user, Permission::ReadSbom)?; | ||
| Ok(HttpResponse::Ok().json(service.status(()).await?)) | ||
| Ok(HttpResponse::Ok().json(service.status(&**db).await?)) |
There was a problem hiding this comment.
I love concise code, but is this a tad too magic? I can't know at a glance what &**db is doing. Are we taking a reference of the result of calling first the Deref impl of web::Data and then that of Database? I'm not a rust noob, and I'm not sure. 😄
Is something like service.status(db.get_ref().connection()) too wordy or less idiomatic?
There was a problem hiding this comment.
We could use db.as_ref() instead. Would do the same. You'd prefer that?
There was a problem hiding this comment.
Are we taking a reference of the result of calling first the
Derefimpl ofweb::Dataand then that ofDatabase?
Btw, close: The first Deref takes the Arc from web::Data, the second takes T (Database) from the Arc.
There was a problem hiding this comment.
Replaced this with db.as_ref().
ctron
force-pushed
the
feature/pass_tx_1
branch
from
693f0e7 to
398b96c
Compare
ctron
added
the
DB
Directly use the `ConnectionTrait` from sea_orm.
ctron
force-pushed
the
feature/pass_tx_1
branch
from
398b96c to
864f467
Compare
Directly use the
ConnectionTraitfrom sea_orm.