feat: add devcontainers #7
Conversation
There was a problem hiding this comment.
Thanks for adding this @carlosthe19916 It is a great addition to have on our repository. I have added a clarification and a addition on README.md. Please let me know your thoughts.
While building the devcontainer I am getting an error
I have updated the extension settings
podman sockets are configured as well
Please let me know if I am missing anything.
|
|
||
| - `Dev › Containers: Docker Compose Path` set `podman-compose` | ||
| - `Dev › Containers: Docker Path` set `podman` | ||
| - `Dev › Containers: Docker Socket Path` set `/run/podman/podman.sock` |
There was a problem hiding this comment.
Can you please add a step on running a devcontainer in vscode like "ctrl+shift+p" to open command palette and enter "Dev Containers: Rebuild and Reopen in Container"
.devcontainer/template.json
Outdated
| }, | ||
| "onCreateCommand": "npx playwright install-deps && npx playwright install", | ||
| "postCreateCommand": "npm ci", | ||
| "postStartCommand": "echo \"source /usr/share/bash-completion/completions/git\" >> ~/.bashrc", |
There was a problem hiding this comment.
I am not sure why we needed the git completion on bash.
|
I still cannot reproduce the error but I will try to. Note: it took me some time to configure it to work with Podman as Docker is the default choice. There might be something I might be missing definitely. |
This PR adds Devcontainers so developers can have a "ready to use" environment based on Ubuntu and with all configuration prepared for Playwright.
As described by https://github.com/trustification/trustify-ui-tests/blob/main/DEVELOPING.md if you have Fedora then you might find certain limitations. Personally I didn't find any so far but the use cases I had might have been basic I guess. So this should help scenarios where Ubuntu (supported OS for Playwright) is needed.
I personally find Devcontainers very useful and I tend to use it everywhere but I am not sure if others will find it useful. I am sharing it here as an alternative to https://github.com/trustification/trustify-ui-tests/blob/main/DEVELOPING.md . If people find it useful we can use it in other projects too but let's start here.
@mrrajan as you created DEVELOPING.md describing the limitations of OS like Fedora, perhaps you could review this PR and validate whether or not it works also for you :)