Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright + Cucumber: Working version #12

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

carlosthe19916
Copy link
Member

No description provided.

@queria
Copy link
Contributor

queria commented Jan 16, 2025

Hm seeing the e2e github check failing, it made me realize we want want to structure/tag/... the feature files in a way we can select subsets of which to execute:

  • not all of tests may fit all envs/setups (e.g. may need longer execution time/resources, e.g. multiuser, need cves ingested etc)
  • may be specific for only part/subset of ui (selective triggering on PRs?)

Not saying it would be needed right now, but maybe we could start with such set for what we want enabled in github checks.

@@ -30,3 +30,10 @@ npx playwright test
```shell
npm run test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be good to also mention here the other modes of operation,
like which situation they can be used for please?

(e.g. the test:trace, test:host or any other useful tips for debug/devel)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@carlosthe19916 carlosthe19916 marked this pull request as ready for review January 21, 2025 13:58
@carlosthe19916
Copy link
Member Author

@vobratil @queria I changed the status of this PR to "Ready to be reviewed".
I will be out for the rest of week and I could not manage to be in contact with you guys, my apologies.

What I would suggest is to review this PR and if approved it can be merged. The feature implementations in this PR should be taken as a guidelines only because the final features will be the ones you all are defining in the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants