-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright + Cucumber: Working version #12
base: main
Are you sure you want to change the base?
Conversation
Hm seeing the e2e github check failing, it made me realize we want want to structure/tag/... the feature files in a way we can select subsets of which to execute:
Not saying it would be needed right now, but maybe we could start with such set for what we want enabled in github checks. |
# Conflicts: # package.json
@@ -30,3 +30,10 @@ npx playwright test | |||
```shell | |||
npm run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be good to also mention here the other modes of operation,
like which situation they can be used for please?
(e.g. the test:trace
, test:host
or any other useful tips for debug/devel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks
@vobratil @queria I changed the status of this PR to "Ready to be reviewed". What I would suggest is to review this PR and if approved it can be merged. The feature implementations in this PR should be taken as a guidelines only because the final features will be the ones you all are defining in the other PRs. |
No description provided.