feat: implement all nine invalid and boundary test specifications for… - #145
Merged
meshackyaro merged 3 commits intoAug 30, 2026
Merged
Conversation
… multisig operation
…ules to eslint.config.mjs
…cs coverage check
|
@D-Bluemoon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Hi! I've implemented the public export surface integration test along with the automated document drift verification script. The changes have been pushed to this branch and are ready for workflow approval and review! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… multisig operation
Closes #141
Description
Adds missing negative input and invalid-input validation coverage for
MultiSigEscrowClient.initMultiSigOperationto prevent silent regressions across the seven parameter branches. Also implements critical boundary verification and unauthorized signer checks.Tasks Status
_validateInitParams(including networkPassphrase mismatch and duplicate signers).threshold === signers.length).threshold > signers.length).addSignature.Closes #128
Description
Removes the dead legacy
.eslintrc.jsonconfiguration file, which is completely ignored and unsupported by the currenteslint@^10toolchain. Authoritative rules have been successfully ported over to the active flat configuration file (eslint.config.mjs) to maintain maximum code quality standards without dropping baseline validation hooks.Infrastructure Improvements
no-throw-literal,no-param-reassign,strict-boolean-expressions) directly into the modern flat-config array..eslintrc.jsonfile.Closes #140
Description
Implements public export surface validation and automated documentation drift testing. This prevents future synchronization drift between the SDK entry point barrel surface (
src/index.ts) and the public-facing documentation (docs/API.md), explicitly safeguarding critical exports likeTrustFlowError.Acceptance Criteria Status
tests/integration.test.tsto validate a maintained allowlist of core exported items.TrustFlowErrorthrough explicit target assertions.scripts/check-doc-coverage.js) to parse public module components and verify their presence within markdown documentation headers.