Added deluserfromgroup bof #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freefirex
requested changes
Jan 2, 2025
| { | ||
| NET_API_STATUS dwErrorCode = NERR_Success; | ||
| LOCALGROUP_MEMBERS_INFO_3 mi[1] = {0}; // https://learn.microsoft.com/en-us/windows/win32/api/lmaccess/ns-lmaccess-localgroup_members_info_3 | ||
| mi[0].lgrmi3_domainandname = intAlloc(1024); |
There was a problem hiding this comment.
this memory should be freed using intFree()
| return; | ||
| } | ||
|
|
||
| if (lpswzDomainName == NULL && lpswzHostName != NULL) |
There was a problem hiding this comment.
In the description all of the available arguments are listed as required
If I give both a hostname and a domain name, SUCCESS. will be printed but nothing will happen.
I'd split this into two aliases one to remove a user from a computer local group and one to remove it from a domain group. Then you can enforce this logic in the cna script easily.
barring that the cna shouldn't list everything as required and should explain what is expected for local vs domain group deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.