-
Notifications
You must be signed in to change notification settings - Fork 8
Add design for the boot phases #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2118f3 to
df3ef39
Compare
travier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds great! Thanks
|
Does that mean that we will need two IP/URL for the trustee servers (KBS1 & 2)? How does the node know to go the the second one after the attestation on first boot? We will also need to figure out how we can tie a connection to a node ID for the second boot (that's not a new problem, we already had this). |
I think we can do it in 2 ways, either with 2 IPs and KBS services or the KBS can interpret the constant path for the firstboot secret and trigger the phase for the key generation. However, for the latter, it isn't implemented by trustee so we will need to add this on top of the kbs offered by trustee.
Since the plan is to implement the clevis pin we could specify the 2 URL as 2 different parameters for the pin. We will register the second URL for the standard KBS to contact for second boot.
This needs to be figure out at the end of the first phase when the LUKs key needs to be registered in As far as it regards the provider ID, this is a mandatory field in the Machine object but it isn't necessarily present inside the node. So, my guess is that we will need to rely on the IP of the connection and then somehow match it with what is available in the environment. |
|
As far as it regards providers which don't set the IP in the Machine, we would need to use their API. In any case, the fallback plan to the Machine object was to use each provider APIs, so this won't be different then the case without the Machine object. It will be nice to check if each provider can somehow advertise if they expose the IP address without the need of checking into the code of each provider. I will ask the cluster api community if there is such an option. The list of capi providers is quite large, but we are interested only on those who support confidential computing. |
c8983d2 to
ce15552
Compare
|
/hold wait until we clarify the node identifier, this might change the design |
f274adc to
fd1cc0c
Compare
|
This registration service is only needed if we can not get the node id from OpenShift |
1e76ec9 to
c149b45
Compare
9f79757 to
bb29fb4
Compare
|
/cc @Jakob-Naucke |
e9bba47 to
1880fa7
Compare
|
@travier @Jakob-Naucke I'd like to merge this since we have already more or less implemented. |
travier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits but LGTM.
|
@Jakob-Naucke @travier PTAL |
Signed-off-by: Alice Frosi <[email protected]>
|
I pushed a few nits. LGTM. |

Design proposal for the booting process