This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: Add new demo page to handle issuance initiate request and qrcode scanner #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talwinder50
requested review from
sudeshrshetty and
rolsonquadras
and removed request for
rolsonquadras and
sudeshrshetty
talwinder50
changed the title
talwinder50
requested review from
sudeshrshetty,
rolsonquadras and
fqutishat
rolsonquadras
suggested changes
Sep 19, 2022
talwinder50
force-pushed
the
qrcode
branch
2 times, most recently
from
fc67a85 to
7209f26
Compare
cmd/wallet-web/src/router/routes.js
Outdated
| @@ -184,6 +184,11 @@ export default [ | |||
| name: 'block-no-auth', | |||
| component: load('pages/BlockNoAuthPage'), | |||
| }, | |||
| { | |||
| path: 'initiateIssuance', | |||
There was a problem hiding this comment.
Can we rename this to initiateProtocol ? This will be used for presentation along with issuance. Also, need to update page name as well
Signed-off-by: Talwinder Kaur <[email protected]>
rolsonquadras
approved these changes
Sep 21, 2022
fqutishat
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-09-20.at.11.06.52.PM.mov
closes #1879
closes #1875
Signed-off-by: Talwinder Kaur [email protected]