Skip to content
This repository was archived by the owner on Jan 12, 2023. It is now read-only.

Conversation

nelztruss
Copy link
Contributor

I tried to make each of the commits self-contained (they could have each been their own PRs, but didn't wanna spam everyone with small nickel-and-dime changesets):

  1. there was still some usage of the "old" logging pattern, this commit replaced those usages with the new logging pattern
  2. as Mikena called out in Request Logging #1, no need to make the services log the userID, that can be handled within the middleware layer that puts the User object onto the context
  3. as proposed in Request Logging #1, setting the whole request log line to "error" status didn't need a separate error_message field, the existence of the error itself is enough to signal setting the level appropriately
  4. appease the linters

@nelztruss
Copy link
Contributor Author

(The build error is just saying that this hasn't been configured for running in GH Actions. 🤔 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant