This repository was archived by the owner on Jan 12, 2023. It is now read-only.
This is an example of testing using the httpbaselinetest library #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahobson
commented
Sep 3, 2020
ahobson
commented
- Centralize config extraction and initialization
- Auth middleware no longer continues if auth fails
- POST dog sets content-type because it returns JSON
added 2 commits
August 27, 2020 17:03
* Auth middleware no longer continues if auth fails * POST dog sets content-type because it returns JSON
nelztruss
reviewed
Sep 8, 2020
| if err != nil { | ||
| validationErr := apperrors.NewValidationError( | ||
| errors.New("GET dog params failed validation"), | ||
| fmt.Errorf("GET dog params failed validation: %s", err), |
There was a problem hiding this comment.
Why not take it even one step further and use the wrapping %w verb introduced in Go 1.13?
There was a problem hiding this comment.
Thank you! I'll confess that I remembered that the best practices for error handling in go had changed over time, but I didn't remember the right idiom.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.