Inner mutability improvements #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
thread-safe-improvements
branch
2 times, most recently
from
e3394cc to
bf725ca
Compare
This also a breaking change because the `unsafe` `open` function did not take the correct lifetime. It think it's an acceptable breaking change because the previous behaviour was buggy and any code that depends on it likely has a use after free.
`Filesystem` is still `!Sync`, so this allows putting the filesystem behind a `Mutex` and sharing it across threads but still prevents concurrent operations from multiple threads. See trussed-dev#108 (comment)
sosthene-nitrokey
force-pushed
the
thread-safe-improvements
branch
from
bf725ca to
9758ff3
Compare
sosthene-nitrokey
force-pushed
the
thread-safe-improvements
branch
from
1b528ff to
2c7311e
Compare
robin-nitrokey
approved these changes
Sep 8, 2025
daringer
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a lifetime issue with the
File::openfunctionThis contains a breaking change because the
unsafeopenfunctiondid not take the correct lifetime.
It think it's an acceptable breaking change because the previous behaviour was wrong
and any code that depends on it likely has a use after free.
Make Filesystem Send
Filesystemis still!Sync, so this allows putting the filesystem behind aMutexand sharing it across threads but still prevents concurrent operations from multiple threads.
Close #109
@Ddystopia and @Psy-Kai this might interest you