Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fileName to Handler readerConfig #3651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fileName to Handler readerConfig #3651

wants to merge 1 commit into from

Conversation

mcastorina
Copy link
Collaborator

Description:

Tracks the file name in addition to its extension for use by handlers.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@mcastorina mcastorina requested review from a team as code owners November 21, 2024 20:38
joeleonjr
joeleonjr reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@joeleonjr joeleonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition! I'm sure this will come in handy as the handlers improve and grow.

rosecodym
rosecodym approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but what motivated this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeleonjr joeleonjr joeleonjr left review comments

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcastorina @rosecodym @joeleonjr