-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133308 / 25.04 / Remove call for buckets when not correct role. Adds readonly
to ix-explorer
#11289
base: master
Are you sure you want to change the base?
Conversation
readonly
to ix-explorer
readonly
to ix-explorer
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11289 +/- ##
==========================================
+ Coverage 82.55% 82.83% +0.27%
==========================================
Files 1658 1654 -4
Lines 59114 58974 -140
Branches 6215 6196 -19
==========================================
+ Hits 48803 48849 +46
+ Misses 10311 10125 -186 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the calls are not being made.
Changes:
Remove call for buckets when not correct role. Adds
readonly
toix-explorer
Testing:
See the ticket description for testing. Also test the readonly option on the explorer.