Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133308 / 25.04 / Remove call for buckets when not correct role. Adds readonly to ix-explorer #11289

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

RehanY147
Copy link
Contributor

Changes:

Remove call for buckets when not correct role. Adds readonly to ix-explorer

Testing:

See the ticket description for testing. Also test the readonly option on the explorer.

@RehanY147 RehanY147 requested a review from a team as a code owner January 6, 2025 01:34
@RehanY147 RehanY147 requested review from undsoft and removed request for a team January 6, 2025 01:34
@bugclerk
Copy link
Contributor

bugclerk commented Jan 6, 2025

@bugclerk bugclerk changed the title Remove call for buckets when not correct role. Adds readonly to ix-explorer NAS-133308 / 25.04 / Remove call for buckets when not correct role. Adds readonly to ix-explorer Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (9e50429) to head (2bd9350).
Report is 12 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ms/components/ix-explorer/ix-explorer.component.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11289      +/-   ##
==========================================
+ Coverage   82.55%   82.83%   +0.27%     
==========================================
  Files        1658     1654       -4     
  Lines       59114    58974     -140     
  Branches     6215     6196      -19     
==========================================
+ Hits        48803    48849      +46     
+ Misses      10311    10125     -186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the calls are not being made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants