Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133378 / 25.04 / Fix checkin.spec.ts after Slide In migration #11281

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 3, 2025

Testing:

Code review.

@undsoft undsoft requested a review from a team as a code owner January 3, 2025 19:35
@undsoft undsoft requested review from RehanY147 and removed request for a team January 3, 2025 19:35
@bugclerk
Copy link
Contributor

bugclerk commented Jan 3, 2025

@bugclerk bugclerk changed the title NAS-133378: Fix checkin.spec.ts after Slide In migration NAS-133378 / 25.04 / Fix checkin.spec.ts after Slide In migration Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.77%. Comparing base (a39dbfd) to head (509cb48).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11281      +/-   ##
==========================================
+ Coverage   82.54%   82.77%   +0.23%     
==========================================
  Files        1653     1653              
  Lines       58967    58967              
  Branches     6202     6202              
==========================================
+ Hits        48674    48812     +138     
+ Misses      10293    10155     -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed 👌

@undsoft undsoft enabled auto-merge (squash) January 7, 2025 15:41
@undsoft undsoft merged commit 14ba406 into master Jan 7, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133378 branch January 7, 2025 16:21
@bugclerk
Copy link
Contributor

bugclerk commented Jan 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants