-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132626 / 25.04 / Fix styles for contract mentions on sys-info widgets on the dashboard #11272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So two things:
- Text is not aligned for me:
- I don't know how silver international is going to be represented on MW, but if it's going to be
SILVER_INTERNATIONAL
like other enums, this is going to result inSilver_international Contract
on main dashboard andContract Type: SILVER_INTERNATIONAL
on Support card in settings.
Please check with MW on what value we should expect incontract_type
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11272 +/- ##
=======================================
Coverage 82.83% 82.84%
=======================================
Files 1659 1660 +1
Lines 59360 59376 +16
Branches 6232 6234 +2
=======================================
+ Hits 49170 49189 +19
+ Misses 10190 10187 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First point was addressed, second point – wasn't.
You can find a link to MW PR with a list of all licenses in the ticket. It's my understanding that they'll be changed to UPPERCASE when being sent to UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with mocks, as there is some issue with webui.main.dashboard.sys_info
endpoint.
This is good to merge after enum is updated.
@@ -33,7 +33,7 @@ describe('WidgetSysInfoActiveComponent', () => { | |||
version: 'TrueNAS-SCALE-24.10.0-MASTER-20240301-233006', | |||
codename: Codename.ElectricEel, | |||
license: { | |||
contract_type: 'BEST', | |||
contract_type: ContractType.Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume BEST was added here as a mock data and is not an actual name of the contract type.
If so, it's better to replace it here with something else instead of adding a fake value to the enum.
This PR has been merged and conversations have been locked. |
Changes:
Fix styles for contract mentions on sys-info widgets on the dashboard
Testing:
Change the license to "Silver International" and see that the styles look good for system info widgets.