NAS-133655 / Fix app portal URI normalization for IPv6 URIs #15431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortie
changed the title
|
@mortie thanks for the PR! We haven't forgot about it, just trying to wrap up a few other things before we freeze for Fangtooth BETA. Someone should be able to review this soon. |
|
No worries :) I'm in no rush |
Qubad786
reviewed
Jan 22, 2025
| # We already assume that host_ip doesn't contain a port number, | ||
| # so checking if it contains a ':' should be sufficient to determine | ||
| # whether or not it's an IPv6 address. | ||
| if ':' in host_ip: |
There was a problem hiding this comment.
@mortie we have added changes where apps now will already have the portal URI normalized if they are ipv6 based (
).However people who are using apps which were installed/modified before they come to this version, they will run into this issue. Based off this, we definitely would not want to have this normalized 2 times so we should check that [ is not already present and : is present and then normalize it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I reported here: https://ixsystems.atlassian.net/browse/NAS-133655
There's a more thorough investigation there, but basically, when accessing TrueNAS over IPv6, the "Web UI" button in the application detals pane would be broken. This is because it would try to parse
http://<IPv6 address>:<port>as a URL, which doesn't work. The front-end gets the URL from the function I modified here.