Make platform integrations run idempotently #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng logic and improve error handling Simplify the cluster provisioning process by consolidating HTTP requests and error handling. Replace manual curl requests with the make_request function for consistency. Comment out unused variable extraction and introduce default values for log files. Enhance readability and maintainability by reducing redundancy and improving logging.
…ding input from stdin for Terraform integration
…for cleaner output
… to return boolean status refactor(setup_truefoundry_cluster.sh): remove redundant API_KEY and CONTROL_PLANE_URL checks in setup_provider_account function feat(setup_truefoundry_cluster.sh): enhance logging for cluster status in main function
…gnments for log file variables
… and error handling for non-generic clusters
dunefro
reviewed
Jan 2, 2025
dunefro
reviewed
Jan 2, 2025
dunefro
requested changes
Jan 2, 2025
…ng and provider account setup by removing redundant echo statements and simplifying conditional checks
dunefro
reviewed
Jan 2, 2025
dunefro
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.