move data to separate file; add link field to data; save locations to… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but this feature is not necessary for my case. Besides, I'd like to keep all JS in one file to reduce unnecessary requests and optimize load time. However, I'll leave this PR open in case others visit this repo and find it useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… local storage
I am just starting to learn data visualization and really like how you used D3. I made a couple modifications toward porting for other projects. The first mini-project using this can be found at
https://alpiepho.github.io/state-web-development-2018-2019-withD3-static/
Thanks again for sharing your work,
Al