Add ability to authenticate with Amster credentials #33
Conversation
phalestrivir
force-pushed
the
feature/amster-authentication
branch
from
ec986d7 to
ce1ba69
Compare
|
|
||
| if ( | ||
| state.getCookieValue() && | ||
| // !state.getBearerToken() && |
There was a problem hiding this comment.
Did you mean to leave this commented out?
There was a problem hiding this comment.
Yes, it was commented out previously so I left it in, although I could go ahead and delete it since it's not being used. The only reason it says that I added it in is because I did some refactoring and moved some code around
| ); | ||
| }); | ||
|
|
||
| test(`frodo.createInstanceWithAmsterAccount(): FrodoLib is instantiable using factory helper`, async () => { |
There was a problem hiding this comment.
I'm confused by this test. Why are we testing both PKCS#1 and PKCS#8 in the same test and with the assertions interleaved? If we are testing more than one private key format, should we be testing all of the formats like in CryptoUtils.test.ts?
There was a problem hiding this comment.
The reason I tested both was because I needed a case where I create a connection profile using the default Amster journey and one using a custom Amster journey. Plus, if you look at the other tests, each of them create two instances per test as well, so that's why I didn't separate them into separate tests. I tested with different private keys because why not? I guess I could've used the same private key for both of them, I could change it to be like that if you like? We don't need to test all the formats I don't think because we are already testing all the formats in CryptoUtils.test.ts, this test is just testing creating a new connection profile instance.
Add's ability to authenticate with Frodo using Amster private key credentials.