Changes for fr-config-manager commands #30
Conversation
Modified saveJsonToFile function's argument: 'removeRev' to: 'keepRev' as it takes undefined value(empty value) as a value and ignores default value. This change is for more general compatibility.
skootrivir
changed the title
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
@mricketttrivir @skootrivir I just reviewed the PR, there are a lot of changes that need to be made, mostly minor. Work out between you two who will make the changes, and let me know if there are any questions. It will definitely require some changes to be made on the CLI end so that everything works.
phalestrivir
force-pushed
the
config-manager
branch
from
54c4e8c to
d6b5a1d
Compare
…efault, and update tests
phalestrivir
force-pushed
the
config-manager
branch
from
1ebea34 to
7d1a008
Compare
There was a problem hiding this comment.
I just went in and made some various fixes such as running lint, updating tests, etc. However, we still need to remove the RawApi.ts, RawOps.ts, and the changes made to the FrodoLib.ts file. Instead, the function configManagerExportRaw from the CLI that uses it will need to be moved into the FrodoLib. Additionally, instead of passing in the file name, I would just pass in the JSON object inside the file. Let the CLI handle parsing the file. I would put the function in a file called RawConfigOps.ts, and then export the function from the library in FrodoLib as you did with RawOps.ts.
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
RawConfigOps needs tests still, I discovered a bug with it and went ahead and fixed it, but we'll want tests to verify that it works for the future.
Supported commands are:
fr-config-pull all : Get all configuration
fr-config-pull all-static : Get all static configuration
fr-config-pull access-config : Get access configuration
fr-config-pull audit : Get audit configuration
fr-config-pull authentication : : Get authentication configuration
fr-config-pull authz-policies : : Get authorization policies
fr-config-pull connector-definitions : : Get connector cefinitions
fr-config-pull connector-mappings : : Get connector mappings
fr-config-pull cookie-domains : : Get cookie domain config
fr-config-pull cors : : Get CORS configuration
fr-config-pull csp : Get content security policy
fr-config-pull email-provider : Get email provider configuration
fr-config-pull email-templates : Get email templates
fr-config-pull endpoints : Get custom endpoints
fr-config-pull internal-roles : Get internal roles
fr-config-pull journeys : Get journeys
fr-config-pull kba : Get KBA configuration
fr-config-pull locales : Get locales
fr-config-pull managed-objects : Get managed objects
fr-config-pull oauth2-agents : Get OAuth2 agents
fr-config-pull org-privileges : Get organization privileges config
fr-config-pull password-policy : Get password policy
fr-config-pull raw : Get raw config
fr-config-pull remote-servers : Get remote connector servers
fr-config-pull schedules : Get schedules
fr-config-pull saml : Get SAML entities
fr-config-pull scripts : Get authentication scripts
fr-config-pull secrets : Get secrets
fr-config-pull secret-mappings : Get secret mappings
fr-config-pull service-objects : Get service objects
fr-config-pull services : Get authentication services
fr-config-pull themes : Get UI themes
fr-config-pull terms-and-conditions : Get terms and conditions
fr-config-pull test : Test connection and authentication
fr-config-pull ui-config : Get UI configuration
fr-config-pull variables : Get environment specific variables