Fix issue where polly recordings weren't able to be created #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phalestrivir
force-pushed
the
bugfix/fix-polly-recordings
branch
from
95e5cea to
a9d345f
Compare
phalestrivir
force-pushed
the
bugfix/fix-polly-recordings
branch
from
a9d345f to
2879308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is based off of Murphy's fix. It works by basically reverting back to using the HTTP proxy if doing recordings so that the recordings work. Otherwise, it uses the http or https agents as before. However, not sure if the fix is ideal, there might be a better way to do it.