Add export/import for esv secret store #27
Conversation
phalestrivir
force-pushed
the
feature/add-export-for-esv-secret-store
branch
from
c242b5b to
528e9c5
Compare
…or secretstore commands.
phalestrivir
force-pushed
the
feature/add-export-for-esv-secret-store
branch
from
0f2f56e to
326b72e
Compare
src/ops/SecretStoreOps.test.ts
Outdated
| test('0: Method is implemented', async () => { | ||
| expect(SecretStoreOps.createSecretStoreMapping).toBeDefined(); | ||
| }); | ||
| //TODO: create tests |
There was a problem hiding this comment.
@phalestrivir what is the LOE to create the missing test?
There was a problem hiding this comment.
For this missing test, I think it would be pretty simple to do, we'd just create a new secret store mapping (make sure it doesn't already exist) and record it. It wouldn't take more than probably 15-30 minutes. However, there are other missing tests as well for updates and deletes which haven't been implemented either, the main reason being that we are already testing the in the CLI by testing imports and deletes. It will probably take a few hours to get them all implemented, so I will start getting those implemented soon when I have some time to work on it.
There was a problem hiding this comment.
I added the missing tests and got the classic on-prem AM deployment tests passing, but the cloud ones are currently failing due to the fact that I wasn't able to get new recordings for those created since the Frodo dev tenant is down at the moment. Once the Frodo dev tenant is back up, I can go and add in recordings for the cloud tests.
There was a problem hiding this comment.
@hfranklin All the tests are added now, including both the cloud and on prem ones.
Corresponding Frodo-Cli PR here