Skip to content

Conversation

@skootrivir
Copy link

Built with modified frodo-lib, the new code will detect 'idm' deployment type and support export/import/list commands for the following entities:

idm
Email templates
Mappings
Roles
It will also work with 'config export' and 'config import' commands for IDM as well. it will only export the 4 entities with IDM.
It might create an unhandled error when attempting 'config import' for other deployment types' exported config file.
So it will only support importing the exported config files/file from IDM deployment type.

I added tests for IDM deployment types and updated some of the snapshots and it passed every tests.

Copy link
Collaborator

@phalestrivir phalestrivir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this PR since I approved it earlier in this PR: #25

@skootrivir Was there a reason why the old one was closed? I can't remember

@skootrivir
Copy link
Author

skootrivir commented Sep 26, 2025

I approved this PR since I approved it earlier in this PR: #25

@skootrivir Was there a reason why the old one was closed? I can't remember

This was due to our conversation on Google chat.

Here is the copy of our chat :
"
Me, Aug 22, 11:33 AM
Hey Preston, I just remembered that I built the extract idm script feature off of add-on-prem-idm branch, which makes it a little tricky for PR purposes. Any suggestions?

Preston Hales, Aug 22, 11:38 AM
I could come and help you out with that once I'm done with my meeting, I did something like this earlier this week for another Frodo PR that someone made
Basically, you would want to create a new branch off of add-on-prem-idm, and then pull your code from your branch into it and push it to the TriVir repo
"

Implementing and testing for on prem idm

ran lint

Modified based on the review

changes on deployment types

Fix linting, and clean up a few other things.

tests changes

Lint fixes

Remove obsolete snapshots and recordings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants