-
Notifications
You must be signed in to change notification settings - Fork 2
Add alias support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
53597e3 to
8ea121f
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs a few minor changes (see the comments).
Additionally, it needs tests. You will need 3 client_cli tests for the 3 new commands (frodo conn alias, frodo conn alias add, and frodo conn alias delete) and you will want to create 2 e2e tests, one for the add and one for delete. You will also need to update the existing tests as well since I know for sure one of them is currently failing (the client_cli one for frodo conn).
Additionally, you'll want to make sure to run npm run lint:fix. There are a few unused imports that didn't get deleted, and unfortunately this command doesn't fix those, but it does print out the errors to the console. When you run npm run lint:fix, you should only see 2 warnings about deprecated functions, and you can ignore those.
phalestrivir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I missed in my last review was that we should update the conn list and conn describe commands to display any aliases for the connection profiles, as right now there isn't a way to see what aliases are part of which profiles without going into the Connections.json file directly. Remember to update the tests for these as well once you make the changes.
phalestrivir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the changes to the descriptions of the commands, tests are failing. You will need to update the client_cli test snapshots again.
Also, make sure to run npm run lint:fix, there is a lint fix that needs to be applied to the SampleData.ts file you modified (don't include the lint fixes for the JourneyOps file since those are irrelevant to this PR).
ecfb096 to
97a27a4
Compare
97a27a4 to
2c8f4e3
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes requested
All commands will now check for an alias before a substring. Aliases can be set for existing connection profiles or upon saving a new connection profile.