Promotion tool2 #23
Promotion tool2 #23
Conversation
…edApplications, agent, policy, idm, scripts, resourcetype, authentication, email template, oauth client, and journeys tests.
| "uuid": "^9.0.0", | ||
| "yesno": "^0.4.0" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
Should these be devDependencies?
| ) | ||
| .addOption( | ||
| new Option( | ||
| '-E, --frodo-export-dir <directory>', |
There was a problem hiding this comment.
I'd lean towards lowercase flags when possible.
| ) | ||
| .addOption( | ||
| new Option( | ||
| '--propmt-prune', |
| ) | ||
| .addOption( | ||
| new Option( | ||
| '-S --effect-secrets', |
| ) | ||
| .addOption( | ||
| new Option( | ||
| '--target <host url>', |
There was a problem hiding this comment.
Is this necessary? The promotion staging should all be for the single environment for now.
| ); | ||
| if ( | ||
| (await getTokens(false, true, deploymentTypes)) && | ||
| options.masterDir && |
There was a problem hiding this comment.
Reorder to validate option prior to making the request for tokens
| break; | ||
| } | ||
| case 'resourcetype': { | ||
| const keysToRemove = [ |
There was a problem hiding this comment.
Do we just remove the metadata instead of individual keys?
There was a problem hiding this comment.
We could make a method that does something similar to that but these export with the metadata even when the flag is there to remove the metadata because I think they are part of the object in a different way
There was a problem hiding this comment.
Yes, when the exports are done, some objects do have the metadata as part of them. The saveToFile and saveJsonToFile functions that save the export are what eventually remove it (if it exists) or add them (if it doesn't exist) to the export when it is written to a file. You can simply do delete obj.meta to delete the metadata if it exists. However, I realized these keys might be attributes of the object instead and not part of the meta object, in which case we probably do need to have it remove the individual keys if we want to ignore those.
| export default function setup() { | ||
| const program = new FrodoCommand('frodo idm delete'); | ||
|
|
||
| interface ServiceDeleteOptions { |
There was a problem hiding this comment.
Left over dead code from copying the service command.
| } | ||
|
|
||
| program | ||
| .description('Delete AM services.') |
There was a problem hiding this comment.
Update descriptions to be descriptive of idm and not services
There was a problem hiding this comment.
IDM delete command is not necessary for the promotion, this should be in a separate PR
| command | ||
| ); | ||
|
|
||
| // const globalConfig = options.global ?? false; |
There was a problem hiding this comment.
IDM delete command is not necessary for the promotion, this should be in a separate PR
There was a problem hiding this comment.
The full delete is not necessary but I did have to pull inn the command from the library
| const agent = getJsonObjectTwoDown(importFilePath); | ||
| const agentType = agent._type._id; | ||
| verboseMessage(`Agent id: ${agent._id} and type: ${agentType}`); | ||
| switch (agentType) { |
There was a problem hiding this comment.
The switch statement isn't necessary for agents, I would just stick with the default case since the default case will work for all agent types include the web, java, and IG agents.
| break; | ||
| } | ||
| // Taken care of by Idm | ||
| case 'theme': { |
There was a problem hiding this comment.
Combine the cases so that we only break in one place (like I mentioned previously)
| verboseMessage( | ||
| `Deleting agent '${agent._id}' of type ${agentType} in realm "${state.getRealm()}"...` | ||
| ); | ||
| switch (agentType) { |
There was a problem hiding this comment.
Switch statement not necessary here, default case should suffice for all agent types
| const type = getTypeFromPath(path); | ||
| let promotable: boolean; | ||
| switch (type) { | ||
| case 'cot': { |
There was a problem hiding this comment.
These three cases can be combined into a single case. In fact, since the switch statement isn't all that big, you could probably just do an if statement if you want to.
No description provided.